jackylee-ch commented on code in PR #12470:
URL: https://github.com/apache/gluten/pull/12470#discussion_r3541810543
##########
cpp/velox/tests/CMakeLists.txt:
##########
@@ -28,12 +28,16 @@ function(add_velox_test TEST_EXEC)
add_executable(${TEST_EXEC} ${SOURCES} ${VELOX_TEST_COMMON_SRCS})
target_include_directories(${TEST_EXEC} PRIVATE ${CMAKE_SOURCE_DIR}/velox
${CMAKE_SOURCE_DIR}/src)
+ target_compile_definitions(
+ ${TEST_EXEC}
+ PRIVATE GLUTEN_VELOX_TEST_DATA_DIR="${CMAKE_CURRENT_SOURCE_DIR}/data")
target_link_libraries(${TEST_EXEC} velox ${GLUTEN_ROARING_LINK_LIBRARY}
Review Comment:
Good catch — fixed. `add_velox_gpu_test()` now defines
`GLUTEN_VELOX_TEST_DATA_DIR` symmetrically with `add_velox_test()`, so GPU test
executables that pull in `FilePathGenerator.cc` via `VELOX_TEST_COMMON_SRCS`
compile correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
