zml1206 commented on PR #12475:
URL: https://github.com/apache/gluten/pull/12475#issuecomment-4920976722
> @zml1206, thanks for the fix. One comment, which might be slightly beyond
the scope of this PR. Please check if it makes sense.
>
> I noticed this suite runs all the parent SparkSessionExtensionSuite tests
without the Gluten plugin or any Gluten-specific configuration. Those are
Spark's own tests and can be covered on the Spark side, so there's no need to
run them on Gluten.
>
> Could we use includeGlutenTest("customColumnarOp") to enable only this
Gluten test, where the Gluten plugin and related config are actually applied to
the Spark session? This test was introduced by #4165 and isn't intended to
cover Spark's own tests the way other suites do.
>
> Alternatively, if the test doesn't really depend on
SparkSessionExtensionSuite, could we move it to a new suite under
gluten-ut/test?
Thanks for the suggestion. It makes sense to avoid running the parent
SparkSessionExtensionSuite tests here since they are Spark-side coverage and do
not require Gluten-specific configuration.
I'll update the suite settings to enable only the Gluten-specific test with
includeGlutenTest("customColumnarOp"). I prefer this over moving the test for
now because the test still reuses SparkSessionExtensionSuite helpers, and the
scoped include keeps the PR minimal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
