This is an automated email from the ASF dual-hosted git repository.
rui-mo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 268ae68667 [GLUTEN-12449] Remove unsupported functions in
ArrowWritableColumnVector (#12450)
268ae68667 is described below
commit 268ae68667fcfa0eb0c9848efddf080c03ee0219
Author: Wechar Yu <[email protected]>
AuthorDate: Thu Jul 9 18:40:27 2026 +0800
[GLUTEN-12449] Remove unsupported functions in ArrowWritableColumnVector
(#12450)
---
.../vectorized/ArrowWritableColumnVector.java | 37 ---------------------
.../vectorized/ArrowWritableColumnVectorTest.java | 38 ++++++++++++++++++++++
2 files changed, 38 insertions(+), 37 deletions(-)
diff --git
a/gluten-arrow/src/main/java/org/apache/gluten/vectorized/ArrowWritableColumnVector.java
b/gluten-arrow/src/main/java/org/apache/gluten/vectorized/ArrowWritableColumnVector.java
index 934e2c23bd..10984cf5e6 100644
---
a/gluten-arrow/src/main/java/org/apache/gluten/vectorized/ArrowWritableColumnVector.java
+++
b/gluten-arrow/src/main/java/org/apache/gluten/vectorized/ArrowWritableColumnVector.java
@@ -497,13 +497,6 @@ public final class ArrowWritableColumnVector extends
WritableColumnVectorShim {
return accessor.getBoolean(rowId);
}
- @Override
- public boolean[] getBooleans(int rowId, int count) {
- return accessor.getBooleans(rowId, count);
- }
-
- //
-
//
// APIs dealing with Bytes
//
@@ -538,11 +531,6 @@ public final class ArrowWritableColumnVector extends
WritableColumnVectorShim {
return accessor.getByte(rowId);
}
- @Override
- public byte[] getBytes(int rowId, int count) {
- return accessor.getBytes(rowId, count);
- }
-
@Override
protected UTF8String getBytesAsUTF8String(int rowId, int count) {
return UTF8String.fromBytes(getBytes(rowId, count));
@@ -577,11 +565,6 @@ public final class ArrowWritableColumnVector extends
WritableColumnVectorShim {
return accessor.getShort(rowId);
}
- @Override
- public short[] getShorts(int rowId, int count) {
- return accessor.getShorts(rowId, count);
- }
-
//
// APIs dealing with Ints
//
@@ -616,11 +599,6 @@ public final class ArrowWritableColumnVector extends
WritableColumnVectorShim {
return accessor.getInt(rowId);
}
- @Override
- public int[] getInts(int rowId, int count) {
- return accessor.getInts(rowId, count);
- }
-
/**
* Returns the dictionary Id for rowId. This should only be called when the
ColumnVector is
* dictionaryIds. We have this separate method for dictionaryIds as per
SPARK-16928.
@@ -665,11 +643,6 @@ public final class ArrowWritableColumnVector extends
WritableColumnVectorShim {
return accessor.getLong(rowId);
}
- @Override
- public long[] getLongs(int rowId, int count) {
- return accessor.getLongs(rowId, count);
- }
-
//
// APIs dealing with floats
//
@@ -702,11 +675,6 @@ public final class ArrowWritableColumnVector extends
WritableColumnVectorShim {
return accessor.getFloat(rowId);
}
- @Override
- public float[] getFloats(int rowId, int count) {
- return accessor.getFloats(rowId, count);
- }
-
//
// APIs dealing with doubles
//
@@ -739,11 +707,6 @@ public final class ArrowWritableColumnVector extends
WritableColumnVectorShim {
return accessor.getDouble(rowId);
}
- @Override
- public double[] getDoubles(int rowId, int count) {
- return accessor.getDoubles(rowId, count);
- }
-
//
// APIs dealing with Arrays
//
diff --git
a/gluten-arrow/src/test/java/org/apache/gluten/vectorized/ArrowWritableColumnVectorTest.java
b/gluten-arrow/src/test/java/org/apache/gluten/vectorized/ArrowWritableColumnVectorTest.java
new file mode 100644
index 0000000000..f6b7b4c366
--- /dev/null
+++
b/gluten-arrow/src/test/java/org/apache/gluten/vectorized/ArrowWritableColumnVectorTest.java
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gluten.vectorized;
+
+import org.apache.spark.sql.types.DataTypes;
+import org.apache.spark.task.TaskResources$;
+import org.junit.Test;
+
+import static org.junit.Assert.assertArrayEquals;
+
+public class ArrowWritableColumnVectorTest {
+ @Test
+ public void getBooleansOnStructBackedVectorReturnsExpectedBooleans() {
+ TaskResources$.MODULE$.runUnsafe(
+ () -> {
+ try (ArrowWritableColumnVector vector =
+ new ArrowWritableColumnVector(1, DataTypes.BooleanType)) {
+ vector.putBoolean(0, false);
+ assertArrayEquals(new boolean[] {false}, vector.getBooleans(0, 1));
+ }
+ return null;
+ });
+ }
+}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
