Copilot commented on code in PR #12485: URL: https://github.com/apache/gluten/pull/12485#discussion_r3550925944
########## ep/build-velox/src/get-velox.sh: ########## @@ -17,9 +17,9 @@ set -exu CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd) -VELOX_REPO=https://github.com/IBM/velox.git -VELOX_BRANCH=dft-2026_07_03 -VELOX_ENHANCED_BRANCH=ibm-2026_07_03 +VELOX_REPO=https://github.com/JkSelf/velox.git +VELOX_BRANCH=dft-2026_07_03-remove +VELOX_ENHANCED_BRANCH=ibm-2026_07_03-remove Review Comment: Defaulting VELOX_REPO to a personal fork (github.com/JkSelf/velox) makes Gluten’s Velox build non-reproducible and introduces supply-chain risk (the fork/branches can disappear or diverge unexpectedly). The project docs state Gluten relies on the IBM Velox fork (docs/get-started/Velox.md:81,115), and the script already supports overriding repo/branch via --velox_repo/--velox_branch for developer testing. Please keep the default VELOX_REPO on https://github.com/IBM/velox.git (and only use personal forks via the CLI overrides). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
