LuciferYang opened a new pull request, #12496: URL: https://github.com/apache/gluten/pull/12496
### What changes were proposed in this pull request? Rename the inner `catch (t: Throwable)` binding in `TaskResources.runUnsafe` so it no longer shadows the outer `t`. The inner catch handles a failure of `context.markTaskFailed(t)`; the intent is to attach that follow-up as a suppressed exception to the original body failure, but the shared name currently makes `t.addSuppressed(t)` attach the follow-up to itself. ### Why are the changes needed? Pure diagnostic. On a task where the body throws and `markTaskFailed` also throws, the original exception loses the reference to why cleanup failed. The task still fails with the correct root cause because `throw t` re-raises the outer `t` two lines below. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? `mvn -pl gluten-core -Pspark-3.5 spotless:check` and `compile` pass. Behavior change is limited to the error-suppression chain on a rare double-failure path; no test added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
