jackylee-ch commented on code in PR #12495:
URL: https://github.com/apache/gluten/pull/12495#discussion_r3558319599
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxIteratorApi.scala:
##########
@@ -303,6 +354,21 @@ class VeloxIteratorApi extends IteratorApi with Logging {
}
object VeloxIteratorApi {
+ private[gluten] def buildExtraConf(
+ fsConf: Map[String, String],
+ enableCudf: Boolean,
+ supportsValueStreamDynamicFilter: Boolean): Map[String, String] = {
+ val dynamicFilterConf =
+ if (supportsValueStreamDynamicFilter) {
+ Map.empty[String, String]
+ } else {
+ Map(VeloxConfig.VALUE_STREAM_DYNAMIC_FILTER_ENABLED.key -> "false")
+ }
+ val controlConf =
+ Map(GlutenConfig.COLUMNAR_CUDF_ENABLED.key -> enableCudf.toString) ++
dynamicFilterConf
+ fsConf ++ controlConf
+ }
Review Comment:
Handled in 11724eb11. `buildExtraConf` now accepts only `spark.hadoop.fs.*`
keys before overlaying control settings; the regression test verifies
non-filesystem SQL and UGI keys are dropped.
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala:
##########
@@ -72,6 +72,7 @@ class VeloxBackend extends SubstraitBackend {
override def settings(): BackendSettingsApi = VeloxBackendSettings
override def convFuncOverride(): ConventionFunc.Override = new ConvFunc()
override def costers(): Seq[LongCoster] = Seq(LegacyCoster, RoughCoster)
+ override def interestedPrefixes(): Set[String] = Set("fs.s3a.", "fs.azure.",
"fs.gs.", "fs.")
Review Comment:
Handled in 11724eb11. The prefix set is simplified to `Set("fs.")`,
retaining unknown filesystem schemes while removing redundant scheme-specific
entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
