Copilot commented on code in PR #12503:
URL: https://github.com/apache/gluten/pull/12503#discussion_r3572113334
##########
cpp/velox/tests/VeloxGpuShuffleWriterTest.cc:
##########
@@ -663,6 +665,8 @@ TEST_P(GpuRoundRobinPartitioningShuffleWriterTest,
preAllocForceReuse) {
makeNullableFlatVector<int64_t>({0, 1}),
Review Comment:
`inputStringHasNull` is built from a local vector list that doesn't match
the schema of the other inputs (it omits the trailing `UNKNOWN` column present
in the shared test vectors). This will trip the writer's `rowType_` equivalence
check on subsequent writes. Reuse the shared `inputVectorStringHasNull_`
instead.
##########
cpp/velox/tests/VeloxGpuShuffleWriterTest.cc:
##########
@@ -603,6 +603,8 @@ TEST_P(GpuRoundRobinPartitioningShuffleWriterTest,
preAllocForceRealloc) {
makeNullableFlatVector<int64_t>({0, 1}),
Review Comment:
The locally constructed `intHasNull` RowVector has a different schema than
`inputVectorNoNull_` from `VeloxShuffleWriterTestBase` (it still omits the
trailing `UNKNOWN` column). With the new `rowType_` equivalence checks in the
shuffle writer, this will fail on the second split. Reuse the prebuilt
`inputVectorIntHasNull_` so the row type stays consistent across splits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
