JkSelf commented on PR #12505: URL: https://github.com/apache/gluten/pull/12505#issuecomment-4966955473
@philo-he Thanks for your feedback. Relying only on the existing `GlutenInnerJoinSuiteForceShjOff`, `GlutenOuterJoinSuiteForceShjOff`, and `MiscOperatorSuite` is not enough to thoroughly test SMJ. In fact, enabling this specific test during SMJ development helped us identify and fix several result mismatch issues. If we remove this test from the CI pipeline, future changes could easily break the SMJ functionality. cc @FelixYBW @zhouyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
