Copilot commented on code in PR #12499:
URL: https://github.com/apache/gluten/pull/12499#discussion_r3579149201
##########
cpp/velox/memory/GpuBufferColumnarBatch.cc:
##########
@@ -121,8 +135,8 @@ std::shared_ptr<GpuBufferColumnarBatch>
GpuBufferColumnarBatch::compose(
int32_t bufferIdx = 0;
for (const auto& colType : type->children()) {
size_t rowNumber = 0;
- // Also records the value buffer offset.
- size_t stringOffset = 0;
+ // Also records the length buffer offset for strings.
+ size_t valueBufferOffset = 0;
Review Comment:
This comment is now inaccurate: `valueBufferOffset` tracks the byte offset
into the *value* buffer (including for strings), not the length/offset buffer.
Please update the wording to avoid confusion for future maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
