Copilot commented on code in PR #12533:
URL: https://github.com/apache/gluten/pull/12533#discussion_r3593274832
##########
gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -869,13 +869,13 @@ class VeloxTestSettings extends BackendTestSettings {
// Overridden
.exclude("Query Spark logs with exception using SQL")
enableSuite[GlutenPercentileQuerySuite]
- // TODO: 4.x enableSuite[GlutenRandomDataGeneratorSuite] // 232 failures
+ enableSuite[GlutenRandomDataGeneratorSuite]
Review Comment:
This PR re-enables GlutenRandomDataGeneratorSuite for Spark 4.1, but the
linked tracking issue (#11550) indicates this suite is still disabled due to
232 failures (TimeType-related). Since this PR’s stated goal is fixing
GlutenSetCommandSuite, this extra enablement is likely unintended and may make
Spark 4.1 CI red unless the failures were addressed elsewhere. Consider keeping
it disabled until the underlying failures are fixed (or include the fixes and
update the tracking issue).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
