Copilot commented on code in PR #12565:
URL: https://github.com/apache/gluten/pull/12565#discussion_r3610766430
##########
package/pom.xml:
##########
@@ -163,6 +163,25 @@
<exclude>META-INF/NOTICE.txt</exclude>
<exclude>LICENSE.txt</exclude>
<exclude>NOTICE.txt</exclude>
+ <!--
+ Exclude DefaultAllocationManagerFactory from the shade
bundle.
+ Arrow 16.0.0+'s CheckAllocator inspects the URL of this
class
+ and throws "Unknown allocation manager type to infer" if
the
+ URL does not contain "memory-core", "memory-unsafe", or
+ "memory-netty". When the class is bundled inside
+ gluten-package.jar the URL does not match any of these
+ patterns (in particular for Arrow <= 15.x where the class
+ lives at org/apache/arrow/memory/DefaultAllocationManager
+ Factory.class), breaking allocator initialization
whenever
+ the runtime Arrow version is >= 16.0.0 (e.g. Spark
+ distributions that ship a newer Arrow than Gluten's
Review Comment:
The explanatory XML comment breaks the class path across two lines
("DefaultAllocationManager" + "Factory.class"), which makes the referenced path
inaccurate/confusing. Keeping the full `DefaultAllocationManagerFactory.class`
path on one line will better match the actual excludes below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
