Copilot commented on code in PR #12567:
URL: https://github.com/apache/gluten/pull/12567#discussion_r3610958648
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/BatchScanExecTransformer.scala:
##########
@@ -68,6 +68,8 @@ case class BatchScanExecTransformer(
runtimeFilters = QueryPlan.normalizePredicates(
runtimeFilters.filterNot(_ ==
DynamicPruningExpression(Literal.TrueLiteral)),
output),
+ keyGroupedPartitioning = keyGroupedPartitioning.map(
+ QueryPlan.normalizeExpressions(_, output)),
pushDownFilters = pushDownFilters.map(QueryPlan.normalizePredicates(_,
output))
Review Comment:
Per Gluten's contribution guidance, a regression test should be added for
this bug fix if it isn't already covered. I couldn't find any existing unit
test that exercises BatchScanExecTransformer canonicalization/equality
specifically for keyGroupedPartitioning (no matches for keyGroupedPartitioning
/ KeyGroupedPartitioning-related canonicalization in gluten-ut), so this change
may be unguarded against regressions in AQE exchange reuse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
