LuciferYang commented on code in PR #12583:
URL: https://github.com/apache/gluten/pull/12583#discussion_r3619488966
##########
cpp-ch/local-engine/Storages/SubstraitSource/ReadBufferBuilder.cpp:
##########
@@ -326,8 +326,9 @@ class HDFSFileReadBufferBuilder : public ReadBufferBuilder
{
if (!file_size.has_value())
{
- // only for spark3.2 file partition not contained file size
- // so first compute file size first
+ // Fallback for callers whose Substrait LocalFilesNode was
built without a
+ // fileSize list (e.g. some Iceberg producers). Compute the
size by opening
+ // the HDFS file first.
Review Comment:
Good catch — the producing side uses `fileSizes` (plural, the `List<Long>`
argument to `LocalFilesNode`) to decide whether to set the per-file protobuf
`fileSize` property. Reworded in 8cccb4664 to distinguish the two: `fileSizes`
input vs `fileSize` property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
