LuciferYang commented on code in PR #12590:
URL: https://github.com/apache/gluten/pull/12590#discussion_r3627792827
##########
gluten-core/src/main/scala/org/apache/gluten/extension/injector/GlutenInjector.scala:
##########
@@ -39,7 +38,6 @@ class GlutenInjector private[injector] (control:
InjectorControl) {
}
private def applier(session: SparkSession): ColumnarRuleApplier = {
- val conf = new GlutenCoreConfig(session.sessionState.conf)
Review Comment:
Reverted — kept the `val conf` instantiation. You're right that `new
GlutenCoreConfig(...)` forces `GlutenCoreConfig` object initialization and its
config registration, so removing it is not side-effect-free. Dropped this hunk
from the PR.
##########
gluten-core/src/main/scala/org/apache/gluten/extension/columnar/transition/Transition.scala:
##########
@@ -166,9 +166,6 @@ object Transition {
}
case (ConventionReq.RowType.Any, ConventionReq.BatchType.Any) =>
Transition.empty
- case _ =>
- throw new UnsupportedOperationException(
- s"Illegal convention requirement: $ConventionReq")
Review Comment:
Reverted — kept the `case _` guard. Agreed it's protective against future
additions to the sealed RowType/BatchType hierarchy even though the current 2x2
is exhaustive. Dropped this hunk from the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
