Smallfu666 commented on PR #12605: URL: https://github.com/apache/gluten/pull/12605#issuecomment-5065451654
Good catch — `Cast.evalMode` was added in Spark 3.4 (SPARK-40389, replacing the `ansiEnabled` arg), so the 4-arg form broke the 3.3 build. Fixed in 260154370 with the 3-arg Cast, keeping the outer cast via `withNewChildren`. decimal-to-string is lossless regardless of eval mode, so the outer double cast still carries the ANSI semantics. Verified: Spark 3.3 `test-compile` passes, and MathFunctionsValidateSuite (Spark 3.5, Velox) stays 46/46. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
