malinjawi commented on code in PR #12218:
URL: https://github.com/apache/gluten/pull/12218#discussion_r3645320223
##########
backends-velox/src-delta/main/scala/org/apache/gluten/component/VeloxDeltaComponent.scala:
##########
@@ -35,6 +35,8 @@ class VeloxDeltaComponent extends Component {
}
override def injectRules(injector: Injector): Unit = {
+ injector.spark.injectPlannerStrategy(DeltaCDFScanStrategy(_))
Review Comment:
Yes, good suggestion. I added a dedicated experimental guard in 65178209a:
`spark.gluten.sql.columnar.backend.velox.delta.enableChangeDataFeedScan`
It defaults to `true`, is checked against the active session config on each
planning pass, and setting it to `false` makes `DeltaCDFScanStrategy` decline
the relation so Delta uses its vanilla CDF path. I also added a regression test
for the disabled path and documented the setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
