Copilot commented on code in PR #12729:
URL: https://github.com/apache/gluten/pull/12729#discussion_r3741854684
##########
dev/run-clang-tidy.py:
##########
@@ -128,12 +83,15 @@ def tidy(args):
fix = "--fix" if args.fix == "fix" else ""
files = args.files
+ # Checks come from 'cpp/.clang-tidy'; passing '--checks' here would
override it.
+ # CLANG_TIDY_EXTRA_ARGS forwards toolchain details the compilation
database omits.
+ extra_args = os.environ.get("CLANG_TIDY_EXTRA_ARGS", "").strip()
+
Review Comment:
`CLANG_TIDY_EXTRA_ARGS` is interpolated directly into a shell command
(`shell=True`). If it contains shell metacharacters or newlines, it can break
the invocation (and, outside CI, becomes a command-injection footgun). Consider
normalizing it via `shlex.split` and re-quoting each token before formatting it
into the command string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
