felipepessoto commented on PR #12745: URL: https://github.com/apache/gluten/pull/12745#issuecomment-5257263308
Changed the pattern to `**/*.md` in 3777a642d, though not quite for the stated reason. Per the [filter pattern cheat sheet](https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#filter-pattern-cheat-sheet), `**` "matches any character **including slash (`/`)**", and `'**.js'` is documented as matching `src/js/app.js` — so `**.md` should already have matched at arbitrary depth. That said, `docs/**/*.md` is the spelling the same table documents for "a file with a `.md` suffix anywhere in the `docs` directory", and its examples cover the top-level file (`docs/README.md`) as well as nested ones (`docs/a/markdown/file.md`). Since this pattern has now drawn two review comments, and a silent non-match would mean every README edit costs a full ~10 runner-hour run, the unambiguous spelling is worth more than the terse one. No behaviour change intended: Markdown under the directory is excluded, and `run-delta-tests.sh`, `known-failures.txt` and the workflow itself still trigger the suite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
