JkSelf commented on code in PR #12746:
URL: https://github.com/apache/gluten/pull/12746#discussion_r3764960689
##########
cpp/velox/substrait/SubstraitToVeloxPlan.cc:
##########
@@ -796,6 +796,11 @@ std::shared_ptr<CudfHiveInsertTableHandle>
makeCudfHiveInsertTableHandle(
#endif
core::PlanNodePtr SubstraitToVeloxPlanConverter::toVeloxPlan(const
::substrait::WriteRel& writeRel) {
+ // emit would remap the written columns, which the writer below does not
apply
Review Comment:
@nielspardon Since `WriteRelNode` doesn't use `RelCommon` to pass variables
[here](https://github.com/apache/gluten/blob/b58e654ae1967ef2441cce4d737856b2b801c572/gluten-substrait/src/main/java/org/apache/gluten/substrait/rel/WriteRelNode.java#L42-L55),
this check isn't needed right now. We can re-introduce it if required later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
