Copilot commented on code in PR #12758:
URL: https://github.com/apache/gluten/pull/12758#discussion_r3765693147
##########
gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -746,10 +746,7 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenSparkPlanSuite]
.exclude("SPARK-37779: ColumnarToRowExec should be canonicalizable after
being (de)serialized")
enableSuite[GlutenSparkPlannerSuite]
- enableSuite[GlutenSparkScriptTransformationSuite]
- // Flaky in CI containers for Spark 4.1: intermittently fails with
- // `/tmp/test-resource*.py: Permission denied` and can crash JVM.
- .exclude("SPARK-33934: Add SparkFile's root dir to env property PATH")
+ disableSuite[GlutenSparkScriptTransformationSuite]("Flaky suite")
Review Comment:
The disable reason is very generic. Since this suite is being disabled due
to CI flakiness and JVM crashes, include the concrete symptoms and the tracking
issue/test ID in the reason string so it’s easier to audit and re-enable later.
##########
gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -767,10 +767,7 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenSparkPlanSuite]
.exclude("SPARK-37779: ColumnarToRowExec should be canonicalizable after
being (de)serialized")
enableSuite[GlutenSparkPlannerSuite]
- enableSuite[GlutenSparkScriptTransformationSuite]
- // Flaky in CI containers for Spark 4.0: intermittently fails with
- // `/tmp/test-resource*.py: Permission denied` and can crash JVM.
- .exclude("SPARK-33934: Add SparkFile's root dir to env property PATH")
+ disableSuite[GlutenSparkScriptTransformationSuite]("Flaky suite")
Review Comment:
The disable reason is very generic. Since this suite is being disabled due
to CI flakiness and JVM crashes, include the concrete symptoms and the tracking
issue/test ID in the reason string so it’s easier to audit and re-enable later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
