jackylee-ch commented on PR #12549: URL: https://github.com/apache/gluten/pull/12549#issuecomment-5316739134
@zhztheplayer @philo-he I’ve updated the PR based on the previous discussion. `passToDefault` has been removed, and `createOptional`, `createWithForeignDefault`, and `createWithDefault` are now used to determine whether and how the default value should be propagated to the native side, as described in the PR description. Could you please take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
