marin-ma commented on code in PR #12471: URL: https://github.com/apache/gluten/pull/12471#discussion_r3802478792
########## backends-velox/src/test/scala/org/apache/gluten/execution/CudfBroadcastJoinSuite.scala: ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gluten.execution + +import org.apache.spark.SparkConf + +/** + * Regression tests for GLUTEN-12471: broadcast hash joins on the cuDF (GPU) backend silently + * returned empty results because CudfHashJoin built its hash table from the empty build-side + * iterator instead of the prebuilt CPU table. + * + * These tests require GPU hardware and a cuDF-enabled build, so they are skipped unless the env var + * GLUTEN_TEST_CUDF=1 is set. Run on a GPU host: + * + * GLUTEN_TEST_CUDF=1 mvn test -Pbackends-velox \ + * -DwildcardSuites=org.apache.gluten.execution.CudfBroadcastJoinSuite + */ +class CudfBroadcastJoinSuite extends VeloxWholeStageTransformerSuite { + + override protected val resourcePath: String = "/tpch-data-parquet" + override protected val fileFormat: String = "parquet" + + private def cudfEnabled: Boolean = sys.env.get("GLUTEN_TEST_CUDF").contains("1") Review Comment: Let's not use environment variable to control. You can create a new tag `CudfTest` in backends-velox/src/test/java/org/apache/gluten/tags and append the tag to `-DtagsToExclude` in the CI files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
