malinjawi commented on PR #12215: URL: https://github.com/apache/gluten/pull/12215#issuecomment-5326377100
> @malinjawi @felipepessoto Thank you for the contexts and investigation. > > If there is something else who caused the abnormal row ID, should we fix the bug first and hold this PR off? cc @malinjawi @zhztheplayer With @felipepessoto [velox#18536](https://github.com/facebookincubator/velox/pull/18536) the root cause is now found and fixed at the right layer, so I don't think holding this PR buys anything as the guard is what keeps the affected path off by default until that fix is actually in our pin and proven. I would suggest we merge this (safe default + gate coverage), pull [velox#18536](https://github.com/facebookincubator/velox/pull/18536) in the next bump, then a small follow-up flips `enableNativeDmlRowIndexScan` default once the DV suites pass with output validation on keeping the config as an escape hatch. Huge thanks @felipepessoto for the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
