felipepessoto commented on issue #12784:
URL: https://github.com/apache/gluten/issues/12784#issuecomment-5332522647

   Fixed by #12051 ("[GLUTEN-10134][VL] Preserve store assignment cast modes"), 
merged in 95f280f6da1e7d2467ed5fa52218215e5dce2213.
   
   That PR replaces the boolean `withTryEvalMode` flag with a three-valued 
`CastNode.CastMode` (`TRY` / `ANSI` / `LEGACY`) in `CastTransformer`, and 
plumbs it through `ExpressionBuilder`, `CastNode` and `SubstraitToVeloxExpr.cc` 
(plus the Spark 3.3/3.4/3.5 shims). This is exactly the "propagate the 
per-expression `EvalMode` through Substrait to Velox" fix suggested above, so a 
`Cast` node with `evalMode = LEGACY` no longer inherits ANSI behaviour from the 
session-level `spark.sql.ansi.enabled`.
   
   The Delta CI regressions tracked in #12779 are passing again, and that issue 
has been closed as well.
   
   Closing as completed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to