felipepessoto commented on PR #12778: URL: https://github.com/apache/gluten/pull/12778#issuecomment-5333129658
@philo-he @FelixYBW you are both right, and my wording in the description was wrong. Thanks for catching it. I had described vcpkg's caching as all-or-nothing against the manifest. It isn't: the ABI hash is computed per port, and `Dockerfile.centos9-static-build` bakes in `VCPKG_BINARY_SOURCES=clear;files,/var/cache/vcpkg,readwrite`, so that cache ships inside the image and unchanged ports are restored from it. Only changed ports and their dependents rebuild. I have corrected the PR description and the doc. What is left after dropping that claim still argues for the change, and I think it is a better argument than the one I made: - `dev/ci-velox-buildstatic-centos-9.sh` sets `export NUM_THREADS=2`. That is the right choice for a CI runner and the wrong one for a workstation: it pins the whole Velox build to 2-way parallelism no matter how many cores the container has. That, not vcpkg, is the main reason it runs for hours as a `postCreateCommand`. - The script also turns on `--enable_s3 --enable_gcs --enable_hdfs --enable_abfs` and static linking, which serve release packaging rather than day-to-day development. - @FelixYBW's point is exactly the failure mode I hit and worded badly. Since the ABI hash covers the toolchain as well as the ports, an environment change invalidates everything at once, and vcpkg silently rebuilds without saying why. That is tolerable in CI, where there are logs and a time limit, but in `postCreateCommand` it looks like a container that hangs with no output, and a disconnect leaves a half-built tree behind. Independently of vcpkg, `apache/gluten:vcpkg-centos-9` is missing things a developer needs: `install-spark-resources.sh` is never run in that image, so there is no `/opt/shims` and `gluten-ut` cannot run, and it ships JDK 17 only, while the dynamic image ships JDK 8 and `post-create.sh` adds 17 for the whole Spark matrix. Static linking is still the right default for release jars, and the doc keeps instructions for switching back to the vcpkg image when someone needs to reproduce a static-link problem. The comparison table now says the cache works per port and flags the toolchain caveat, rather than claiming a full rebuild. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
