iemejia commented on PR #12612: URL: https://github.com/apache/gluten/pull/12612#issuecomment-5357420289
Thanks for the review, @malinjawi! Rebased onto latest `main` and pushed. On your side question about `readRawDvBytes` (`skipBytes` vs `seek`): no good reason — I've switched it to `FSDataInputStream.seek(offset)` in 8ca0a20 to match Delta's own `HadoopFileSystemDVStore.read`. `seek` is a positioned reposition (a ranged read on object stores) rather than a read-and-discard, and it avoids `DataInputStream.skipBytes`'s best-effort semantics, where an under-skip would silently misalign the read and fail the CRC check in `readRangeFromStream`. `FSDataInputStream` is a `DataInputStream`, so it passes straight through with no wrapping. I've also updated the PR description to frame this as the real bug fix it is (shallow-clone DV root mis-resolution), per your suggestion. Validated locally: `spotless`/`scalastyle` clean, full `-am` Scala 2.12 / Spark 3.5 reactor build and Scala 2.13 / Spark 4.0 build both green including test sources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
