Copilot commented on code in PR #12829: URL: https://github.com/apache/gluten/pull/12829#discussion_r3833621526
########## .github/workflows/util/delta-spark-ut/README.md: ########## @@ -193,6 +193,11 @@ Delta RoaringBitmapArray row index \d+ exceeds max representable value Delta bitmap row index cannot be negative: -?\d+ Review Comment: The regex example for a "cannot be negative" row index currently allows a missing minus sign (`-?\d+`), which is broader than the described error and undermines the note that patterns should be deliberately specific. Tighten it to match only negative integers. ########## .github/workflows/util/delta-spark-ut/README.md: ########## @@ -193,6 +193,11 @@ Delta RoaringBitmapArray row index \d+ exceeds max representable value Delta bitmap row index cannot be negative: -?\d+ ``` +That example is historical: the root cause was a Velox scan bug +([velox#18535](https://github.com/facebookincubator/velox/issues/18535)), fixed +upstream, so both patterns have since been removed and the suite is enforced +again. It is kept here because it shows the shape of the mechanism. Review Comment: The PR description calls out that this must not merge until Gluten's pinned Velox revision includes the upstream fix commit. The new note says the bug is fixed upstream and the suite is enforced again, but it doesn't capture the dependency on the pinned Velox tag/commit, which risks accidental early merges on other branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
