felipepessoto opened a new pull request, #12853:
URL: https://github.com/apache/gluten/pull/12853

   ## What changes are proposed in this pull request?
   
   Fixes #12850.
   
   Follow-up to #12778, which made the dynamic-link image the default 
development environment.
   
   - Keep `.devcontainer/devcontainer.json` as the default dynamic-link 
configuration for daily Velox development and Spark unit tests.
   - Add `.devcontainer/velox-static/devcontainer.json` for portable jar 
packaging and vcpkg issue reproduction.
   - Share the post-create setup while printing build instructions for the 
selected configuration.
   - Keep dynamic and static ccache/Maven state separate, and persist the 
static image's `/var/cache/vcpkg` binary cache.
   - Keep cloud-filesystem dependencies and native tests disabled in the static 
packaging workflow unless explicitly requested.
   - Select the arm64 vcpkg triplet automatically when the static configuration 
runs on arm64.
   - Document configuration selection in VS Code and Codespaces, image 
limitations, resource requirements and safe switching.
   
   The Spark 4.1 instructions now explicitly switch the dynamic environment 
from its default JDK 8 to JDK 17:
   
   ```bash
   export JAVA_HOME=/usr/lib/jvm/java-17-openjdk
   export PATH="$JAVA_HOME/bin:$PATH"
   java -version  # must report 17
   ```
   
   `buildbundle-veloxbe.sh` adds the Java 17 Maven profile and release target 
for Spark 4.x, but a Maven profile cannot switch the JDK that is already 
running. Without this step Scala fails with `'17' is not a valid choice for 
'-release'`.
   
   ## How was this patch tested?
   
   - Parsed both configurations with `@devcontainers/cli 0.88.0 
read-configuration`.
   - Ran both post-create variants and verified the dynamic Spark 4.1 
instructions, static packaging instructions, unknown-variant failure and 
idempotent arm64 environment setup.
   - Built Spark 4.1 under OpenJDK 17 with the same Maven command used by 
`buildbundle-veloxbe.sh`: `BUILD SUCCESS` in 4:23, producing 
`gluten-package-1.8.0-SNAPSHOT-4.1.jar`.
   - Validated the final static command end to end on CentOS 9/GCC 12/JDK 17 
using the Maven repository and vcpkg binary cache extracted from 
`apache/gluten:vcpkg-centos-9`:
   
     ```bash
     ./dev/buildbundle-veloxbe.sh --enable_vcpkg=ON --build_arrow=OFF \
                                  --spark_version=3.5
     ```
   
     The build processed 124 vcpkg packages, completed in 24:55 and produced 
`cpp/build/releases/libgluten.so` plus the 88 MB 
`gluten-velox-bundle-spark3.5_2.12-linux_amd64-1.8.0-SNAPSHOT.jar`.
   - Ran `bash -n`, the license-header check, `git diff --check` and VS Code 
diagnostics with no errors.
   
   ## Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: GitHub Copilot CLI gpt-5.6-sol
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to