Copilot commented on code in PR #12870:
URL: https://github.com/apache/gluten/pull/12870#discussion_r3841661482
##########
dev/build-helper-functions.sh:
##########
@@ -253,6 +254,7 @@ function setup_linux {
elif [[ "$LINUX_DISTRIBUTION" == "openEuler" ]]; then
case "$LINUX_VERSION_ID" in
24.03)
+ source $GLUTEN_VELOX_SCRIPT_HOME/setup-openeuler24.sh
$GLUTEN_VELOX_SCRIPT_HOME/setup-openeuler24.sh ;;
*)
Review Comment:
`setup_linux` sources `setup-openeuler24.sh` to pick up helper functions,
but that script executes `set -efx -o pipefail` at top-level
(ep/build-velox/src/setup-openeuler24.sh:29). When sourced, those shell options
leak into the caller and can unexpectedly enable `-x` tracing / `errexit` /
`noglob` for the rest of the build script.
Wrap the `source` with save/restore of shell options (or adjust the sourced
script to avoid mutating options when sourced) so the caller’s shell state
remains unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
