Copilot commented on code in PR #12890:
URL: https://github.com/apache/gluten/pull/12890#discussion_r3852487482
##########
gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxSQLQueryTestSettings.scala:
##########
@@ -203,8 +203,6 @@ object VeloxSQLQueryTestSettings extends
SQLQueryTestSettings {
"union.sql",
"using-join.sql",
"window.sql",
- "udf-union.sql",
- "udf-window.sql",
"ansi/cast.sql",
Review Comment:
In Spark 3.4, `GlutenSQLQueryTestSuite.createScalaTestCase` still uses
`contains` matching (not exact), so removing the bare `"udf-union.sql"` entry
actually drops coverage: it was the only supported-list entry that could match
the generated UDF test names like `udf/udf-union.sql - Scala UDF` (and other
UDF variants). If the goal is to keep `udf-union.sql` running on Spark 3.4 (as
it does on 3.5+ via `udf/udf-union.sql - Scala UDF`), re-add it in the correct
`udf/... - Scala UDF` form instead of deleting it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
