marin-ma commented on PR #12838: URL: https://github.com/apache/gluten/pull/12838#issuecomment-5422649100
I wouldn't agree with the changes in #12471 Cudf related execution shouldn't be introduced into `RowVectorStream`. The errors should mostly come from the incorrect shape of the pipeline. We should fix the pipeline construction rather than adding the "RowVector from/to CudfVector" conversions in Gluten. Please continue with solution 2. Based on the current support status, after the fix the correct pipeline for BHJ should be: GPU stage: `GPU Deserialiser (host to device) -> CudfValueStream -> Cudf pipeline -> CudfToVelox (device to host) -> shuffle write/broadcast serialization/c2r/...` CPU stage: `CPU Deserialiser -> RowVectorStream -> CPU pipeline -> shuffle write/broadcast serialization/c2r/...` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
