felipepessoto opened a new issue, #12908:
URL: https://github.com/apache/gluten/issues/12908
## Bug description
**Backend:** VL (Velox)
**Gluten version:** main branch
`.github/workflows/velox_backend_ansi.yml` listens for every created
`issue_comment`, while its workflow-level concurrency group is stable per PR
and has `cancel-in-progress: true`:
```yaml
on:
issue_comment:
types: [created]
concurrency:
group: ${{ github.repository }}-ansi-${{ github.event.issue.number ||
inputs.pr_number }}
cancel-in-progress: true
```
The `/ansi-test` and `/ansi-analyze` command check is only applied later at
`jobs.check-comment.if`. Workflow-level concurrency is evaluated before that
job condition, so any unrelated conversation comment on the same PR can:
1. Start an `issue_comment` workflow in the same concurrency group.
2. Cancel an in-flight `/ansi-test` or `/ansi-analyze` run.
3. Skip `check-comment` because the new comment is not an ANSI command,
leaving no replacement run.
**Expected behavior:** Only a recognized ANSI command or a manual
`workflow_dispatch` run should cancel an older ANSI run for the same PR.
**Actual behavior:** Any newly created PR conversation comment can cancel it.
An unrelated comment on #12902 created skipped ANSI run
[33036933307](https://github.com/apache/gluten/actions/runs/33036933307),
confirming that ordinary PR comments enter this workflow. The same concurrency
ordering caused a confirmed eight-shard Delta Spark UT cancellation and is
fixed for that workflow by #12906.
## Proposed fix
Mirror the command predicate from `jobs.check-comment.if` in
`concurrency.cancel-in-progress`, as #12906 does for `/delta-test`, or route
non-command comments to a unique concurrency group keyed by
`github.run_id`/`github.event.comment.id`.
The latter fully isolates unrelated comments, including from the
single-pending-run replacement behavior of GitHub Actions concurrency. In
either approach, preserve these behaviors:
- A newer `/ansi-test` or `/ansi-analyze` command cancels the older ANSI run
for that PR.
- `workflow_dispatch` can replace an older manual run for the same PR.
- Unrelated issue and PR comments neither cancel nor displace real ANSI runs.
Related: #12906
This issue was written with assistance from GitHub Copilot CLI 1.0.80.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
