zhouyuan commented on code in PR #11186:
URL: https://github.com/apache/gluten/pull/11186#discussion_r3869925906
##########
dev/vcpkg/ports/folly/portfile.cmake:
##########
@@ -60,39 +48,26 @@ vcpkg_cmake_configure(
# https://github.com/facebook/folly/issues/1623
-DFOLLY_NO_EXCEPTION_TRACER=ON
-DMSVC_USE_STATIC_RUNTIME=${MSVC_USE_STATIC_RUNTIME}
- -DCMAKE_DISABLE_FIND_PACKAGE_LibDwarf=OFF
- -DCMAKE_DISABLE_FIND_PACKAGE_Libiberty=ON
- -DCMAKE_DISABLE_FIND_PACKAGE_LibAIO=ON
- -DLIBAIO_FOUND=OFF
+ -DCMAKE_INSTALL_DIR=share/folly
+ -DCMAKE_POLICY_DEFAULT_CMP0167=NEW
+ -DVCPKG_LOCK_FIND_PACKAGE_fmt=ON
+ -DVCPKG_LOCK_FIND_PACKAGE_LibDwarf=OFF
Review Comment:
@boneanxs the diff is introduced by VCPKG itself on folly upgrade. Would you
mind make a patch to fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
