Copilot commented on code in PR #12663:
URL: https://github.com/apache/gluten/pull/12663#discussion_r3869976105
##########
dev/vcpkg/README.md:
##########
@@ -9,8 +9,9 @@ except for those overridden in `vcpkg.json`,
`vcpkg-configuration.json`, and ove
## Build in docker
For main branch code, you can follow the commands below.
-- Pull the docker image: `docker pull apache/gluten:vcpkg-centos-7-gcc13`
-- Build native code: `bash dev/ci-velox-buildstatic-centos-7.sh`
+
+- Pull the docker image: `docker pull apache/gluten:vcpkg-almalinux-8-gcc13`
+- Build native code: `bash dev/ci-velox-buildstatic-centos-8.sh`
- Build JVM code: `mvn clean install -Pbackends-velox -Pspark-3.5 -DskipTests`
Review Comment:
This quick-start uses `mvn` directly. In this repo, Maven should be invoked
via the `./build/mvn` wrapper (it pins the Maven version and JVM flags Gluten
expects), so the documented command should use the wrapper as well.
##########
dev/docker/Dockerfile.almalinux8-gcc13-static-build:
##########
@@ -44,7 +44,7 @@ RUN set -ex; \
dnf install -y ccache; \
# gcc-toolset-13 ships GCC 13 on RHEL8-family via Red Hat Software
Collections. \
dnf install -y --setopt=install_weak_deps=False gcc-toolset-13; \
- dnf install -y java-1.8.0-openjdk-devel patch git wget perl python3
automake libtool flex; \
+ dnf install -y java-1.8.0-openjdk-devel patch git wget perl python3
automake libtool flex bison; \
Review Comment:
`bison` is now baked into the AlmaLinux 8 static-build image here, but
several workflows still run `yum install bison -y` inside the build container.
This adds network/package-manager variability to CI and can also mask whether
the image itself is self-contained. Consider removing those `yum install bison`
steps (or, if CI needs to install it dynamically, drop it from the image
instead).
##########
.github/workflows/velox_nightly.yml:
##########
@@ -184,7 +185,7 @@ jobs:
build-native-lib-centos-8-arm64:
if: ${{ startsWith(github.repository, 'apache/') }}
runs-on: ubuntu-24.04-arm
- container: apache/gluten:vcpkg-centos-8-gcc13
+ container: apache/gluten:vcpkg-almalinux-8-gcc13
Review Comment:
This job now runs in the AlmaLinux 8 vcpkg image (line 188), but the ccache
restore/save keys later in the job are still prefixed `ccache-centos8-...`
(e.g. lines 195 and 212). Reusing ccache across different base
images/toolchains can cause cache pollution and flaky builds; please rename
those keys/restore-keys to an `almalinux8` prefix (consistent with the x86 job
above).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
