LuciferYang commented on PR #12902: URL: https://github.com/apache/gluten/pull/12902#issuecomment-5474051345
Same page, @philo-he. That is PR 2 in this series, and #11687 is the model I had in mind for it: lift the shim methods that exist only because 3.3 diverged into the common trait, inline the ones whose only remaining caller is trivial, drop `getExtendedColumnarPostRules` now that it is always empty, and turn the trait defaults that only 3.3 needed into abstract methods. PR 3 then takes the residual version checks that are not shim APIs (`eqSpark33` and its call sites, the dead `AlignExpandOutputTypes`, the `NativeWritePostRule` registration, the `spark33` helper in the ClickHouse tests) and decides what to do with the five test cases this PR leaves pinned to 3.3. Both are based on this one, so I will open PR 2 once it lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
