philo-he commented on code in PR #12910:
URL: https://github.com/apache/gluten/pull/12910#discussion_r3901509797


##########
gluten-ut/spark33/src/test/scala/org/apache/spark/sql/hive/execution/GlutenHiveUDFSuite.scala:
##########
@@ -53,6 +57,47 @@ class GlutenHiveUDFSuite
     }
   }
 
+  testGluten("HiveGenericUDTF is recognized and mapped by HiveUDFTransformer") 
{

Review Comment:
   I assume such test is independent of the supported Spark versions, and we 
don't need to extend HiveUDFSuite for enabling this test. Then, can we move the 
new tests to a new test suite under gluten-ut/test to avoid duplicate? 
   
   Generally, gluten-ut/sparkxxx should hold the corresponding Spark UTs and 
their variants.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to