Copilot commented on code in PR #12943: URL: https://github.com/apache/gluten/pull/12943#discussion_r3902898889
########## ep/build-velox/src/get-velox.sh: ########## @@ -18,8 +18,8 @@ set -exu CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd) VELOX_REPO=https://github.com/IBM/velox.git -VELOX_BRANCH=dft-2026_08_26_fix -VELOX_ENHANCED_BRANCH=dft-2026_08_26_fix +VELOX_BRANCH=dft-2026_09_01 +VELOX_ENHANCED_BRANCH=ibm-2026_09_01 Review Comment: The PR description links `velox_branch` to `dft-2026_09_01`, but the script sets `VELOX_ENHANCED_BRANCH` to `ibm-2026_09_01`. If the intent is to build the same upstream commit set (or a known enhanced counterpart), consider aligning these branch names or documenting why the enhanced branch differs (and ensuring the enhanced branch exists/contains the expected commits). Otherwise, enhanced builds may unexpectedly diverge from the described upstream baseline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
