Copilot commented on code in PR #12919: URL: https://github.com/apache/gluten/pull/12919#discussion_r3926210397
########## cpp/velox/memory/GlutenDirectBufferedInput.h: ########## @@ -17,11 +17,59 @@ #pragma once +#include <glog/logging.h> + #include "velox/dwio/common/DirectBufferedInput.h" +#include "velox/dwio/common/ExecutorBarrier.h" Review Comment: This header now directly uses `folly::Executor` / `folly::getKeepAliveToken` and `std::unique_ptr`/`std::make_unique`, but it doesn’t include the corresponding Folly/stdlib headers. Relying on transitive includes from Velox headers is brittle and can break builds when upstream headers change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
