LuciferYang commented on PR #12946:
URL: https://github.com/apache/gluten/pull/12946#issuecomment-5535157768
Good prompt, though I landed somewhere slightly different.
I kept the ids naming what the execution adds
(`src-iceberg-spark${spark.plain.version}/test/...`) rather than which profile
owns it, because the profile-based scheme is what created the confusion in the
first place: the `iceberg` profile's own test execution is already called
`add-iceberg-test-sources`, and that is the name that reads as if it belonged
to `iceberg-test`. Renaming by owner would mean renaming that one too, which is
four more executions in a profile the collision does not otherwise touch.
What the comment is really after, though, is that the reason for the
difference should be visible at the point where someone might undo it. So I
said it out loud instead of encoding it in the id:
```xml
<!-- These ids must stay different from the iceberg profile's
add-iceberg-test-sources / add-iceberg-test-resources: Maven merges
plugin
executions by id, so sharing one would drop the other profile's sources
whenever both profiles are active, which is how every in-repo build
runs. -->
```
That also covers the future-collision half of your point better than a
naming convention would, since nothing enforces a convention.
Also merged current main, which moved the two colliding executions from
`pom.xml:1861` and `pom.xml:1912` to `:1833` and `:1884` after #12902 dropped
the `spark-3.3` profile. #12933's line numbers are updated (the description
never carried them). Re-ran the check that matters on the new base:
`test-compile -Pbackends-clickhouse -Pspark-3.5 -Pspark-ut -Pdelta -Piceberg
-Piceberg-test` exits 0 and emits both
`ClickHouseIcebergHiveTableSupport.class` and
`TestPositionDeletesTableGluten.class`, which is the pair that cannot compile
without this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
