jackylee-ch commented on code in PR #12549:
URL: https://github.com/apache/gluten/pull/12549#discussion_r3949761018
##########
gluten-substrait/src/main/scala/org/apache/gluten/backendsapi/BackendSettingsApi.scala:
##########
@@ -170,16 +170,4 @@ trait BackendSettingsApi {
Review Comment:
Deliberate, and I think keeping a deprecated no-op would be the worse option
here.
The two methods were added by `ef309d210`, after v1.7.0, so they are in no
release yet — there is no released API surface to break. Neither is overridden
anywhere in tree (Velox, ClickHouse, or any of the table-format modules); both
only ever had the `Set.empty` default.
The reason not to keep them deprecated: they are *inputs* to conf selection.
A deprecated no-op version would still compile for an out-of-tree backend and
would still return the keys the backend listed, but nothing would read them any
more — the backend would silently stop delivering those confs to its native
side, with no compile error and no warning. Removing the methods turns that
into a compile error at the one place that has to change, which is the outcome
I want for a downstream backend.
The migration is mechanical: whatever keys a backend listed there get
`passToNative()` on their own definitions, and the conf object is exposed
through `Component.confs()`. `docs/developers/NativeConfPassing.md` has a
worked example.
I will add this to the PR description as an upgrade note, together with the
other out-of-tree-facing changes (the `createPartitionWriter` JNI signature,
`columnarShuffleCodec` `Option[String]` → `String`, `benchmarkSaveDir` `String`
→ `Option[String]`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
