Copilot commented on code in PR #12549: URL: https://github.com/apache/gluten/pull/12549#discussion_r3954404784
########## docs/get-started/VeloxS3.md: ########## @@ -173,15 +173,18 @@ Here is the list of hadoop s3 file system configurations: | connection.timeout | 200s |✅| | connection.ttl | 5m |❌| -Gluten new parameters: +Gluten new parameters. The default column is the value **Gluten delivers to native** when the key is +unset, which for some keys deliberately departs from the Hadoop default listed further up - e.g. +`retry.limit` is `7` in Hadoop and `20` here, and `connection.maximum` is `25` in Hadoop and `15` +here. All names below take the `spark.hadoop.fs.s3a.` prefix. Review Comment: The section header says the “Default” column is what Gluten delivers to native when the key is unset, but many keys in this table are not delivered by Gluten unless explicitly set (they rely on native/Hadoop fallbacks). This wording can mislead readers into thinking Gluten always injects these defaults into the native conf map. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
