Copilot commented on code in PR #12981:
URL: https://github.com/apache/gluten/pull/12981#discussion_r3964885025
##########
gluten-core/src/main/scala/org/apache/spark/util/SparkTaskUtil.scala:
##########
@@ -64,25 +64,8 @@ object SparkTaskUtil {
ctors.head
}
Review Comment:
`assert(ctors.size == 1)` can be elided when assertions are disabled, which
would silently change this code to pick an arbitrary constructor if Spark ever
introduces another one. Prefer `require(...)` (not elidable) with a helpful
message so failures are deterministic and easier to diagnose.
##########
gluten-ut/test/src/test/scala/org/apache/spark/sql/GlutenImplicitsTest.scala:
##########
@@ -140,8 +140,7 @@ class GlutenImplicitsTest extends GlutenQueryTest with
SharedSparkSession {
// Spark 3.3 counts one Gluten node here. Since 3.4 the CTAS is
executed as an
// ExecutedCommandExec, which collectFallbackNodes walks past without
counting anything,
// so the summary reports neither a Gluten node nor a fallback node.
Review Comment:
The comment still refers to Spark 3.3 behavior, but Spark 3.3 support has
been removed and this test now asserts the 3.4+ behavior unconditionally.
Updating the comment to describe the current supported behavior will avoid
leaving 3.3-specific guidance behind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
