philo-he commented on code in PR #12990: URL: https://github.com/apache/gluten/pull/12990#discussion_r3982600065
##########
docs/velox-backend-scalar-function-support.md:
##########
@@ -357,73 +352,73 @@
## String Functions
-| Spark Functions | Spark Expressions | Status | Restrictions
|
-|--------------------|-----------------------------|----------|---------------------------------------------------------|
-| ascii | Ascii | S |
|
-| base64 | Base64 | PS | base64 with
chunkBase64String disabled is not supported |
-| bit_length | BitLength | S |
|
-| btrim | StringTrimBoth | S |
|
-| char | Chr | S |
|
-| char_length | Length | S |
|
-| character_length | Length | S |
|
-| chr | Chr | S |
|
-| concat_ws | ConcatWs | S |
|
-| contains | ContainsExpressionBuilder | PS | BinaryType
unsupported |
-| decode | Decode | |
|
-| elt | Elt | |
|
-| encode | Encode | |
|
-| endswith | EndsWithExpressionBuilder | PS | BinaryType
unsupported |
-| find_in_set | FindInSet | S |
|
+| Spark Functions | Spark Expressions | Status | Restrictions
|
+|--------------------|-----------------------------|----------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| ascii | Ascii | S |
|
+| base64 | Base64 | PS | base64 with
chunkBase64String disabled is not supported
|
+| bit_length | BitLength | S |
|
+| btrim | StringTrimBoth | S |
|
+| char | Chr | S |
|
+| char_length | Length | S |
|
+| character_length | Length | S |
|
+| chr | Chr | S |
|
+| concat_ws | ConcatWs | S |
|
+| contains | ContainsExpressionBuilder | PS | BinaryType
unsupported
|
+| decode | Decode | |
|
+| elt | Elt | |
|
+| encode | Encode | |
|
+| endswith | EndsWithExpressionBuilder | PS | BinaryType
unsupported
|
+| find_in_set | FindInSet | S |
|
| format_number | FormatNumber | PS | format_number
only supports tinyint, smallint, integer, bigint, float and double input;
DecimalType input is not supported in Velox<br>format_number with a string
format argument (e.g. '#,###.##') is not supported in Velox; only an integer
number of decimal places is supported |
-| format_string | FormatString | |
|
-| initcap | InitCap | S |
|
-| instr | StringInstr | S |
|
-| lcase | Lower | S |
|
-| left | Left | S |
|
-| len | Length | S |
|
-| length | Length | S |
|
-| levenshtein | Levenshtein | S |
|
-| locate | StringLocate | S |
|
-| lower | Lower | S |
|
-| lpad | LPadExpressionBuilder | PS | BinaryType
unsupported |
-| ltrim | StringTrimLeft | S |
|
-| luhn_check | Luhncheck | S |
|
-| mask | MaskExpressionBuilder | S |
|
-| octet_length | OctetLength | |
|
-| overlay | Overlay | S |
|
-| position | StringLocate | S |
|
-| printf | FormatString | |
|
-| regexp_count | RegExpCount | |
|
-| regexp_extract | RegExpExtract | PS | Lookaround
unsupported |
-| regexp_extract_all | RegExpExtractAll | PS | Lookaround
unsupported |
-| regexp_instr | RegExpInStr | PS | Lookaround
unsupported, group index ignored |
Review Comment:
Should we keep this line unchanged? I assume the unsupported cases are still
present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
