FelixYBW commented on issue #12911:
URL: https://github.com/apache/gluten/issues/12911#issuecomment-5628079094
@zhztheplayer it's the reason:
Why the join isn't enough
`HookedExecutor::join()` is not a thread join despite the name, it's a
timeout, and expiry is only a log line.
```return state_->cv.wait_for(lock, joinTimeout_, [&]{ return
state_->inFlight == 0; });
...
if (!join()) { LOG(WARNING) << "Timed out waiting for hooked executor ..."; }
```
It then proceeds to teardown, and `~VeloxMemoryManager` — which no longer
retries — immediately throws `pools_.size() != 0.` #11882 actually made this
sharper by removing the second-chance loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
