pedrumj2 commented on PR #12976: URL: https://github.com/apache/gluten/pull/12976#issuecomment-5647392527
> @pedrumj2, please check the test failures which should be related. Thanks. @philo-he thanks for catching this. Did you want to take another look before I merge? **TLDR**: - I fixed the broken tests in the latest changes. - I don't think the remaining failures are related **Long Answer**: It seems the tests that were failing are due to the spark tests imports. MapFromArray was used in a several different places in those tests and the new velox implementation changes the exception thats thrown and asserted so those tests fail now. I've seen two approaches in the repo to handle this: - [exclude the tests](https://github.com/apache/gluten/pull/11685) --> minimal copy pasting + loses test coverage - [copy the tests over](https://github.com/apache/gluten/pull/12493) --> keeps test coverage but duplicate code I took the latter approach to avoid losing test coverage. To avoid the code duplication I was thinking maybe we could create a separate issue to refactor the spark side of things to make them more re-usable or track as part of [Issue11216](https://github.com/apache/gluten/issues/11216). As for the remaining test failures they don't seem related. One is failing on Mimo install others seem to be having a transport exception. Please let me know what you think? Thanks again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
