manoj-ragupathy commented on issue #12569: URL: https://github.com/apache/gluten/issues/12569#issuecomment-5669638039
All four PRs are now open. I've opened the whole stack rather than waiting for each to merge, so the full shape of the port is visible for review — but the ordering still matters, and only the first is ready to merge. | PR | Scope | State | |---|---|---| | #13020 | Version-agnostic compatibility fixes (no `spark42` paths) | **Ready for review** | | #13021 | `spark-4.2` profile + `shims/spark42` layer + CI resources | Draft — stacked on #13020 | | #13022 | `gluten-ut/spark42` test module + CI UT jobs | Draft — stacked on #13021 | | #13023 | 52 additional enhanced DSv2 filter tests | Draft — stacked on #13022 | Because GitHub requires PRs to target a branch in this repo, each stacked PR's diff currently also shows its parents' commits. Each description states exactly which top-N commits belong to it. I'll rebase and undraft each one as its parent merges, at which point the diffs shrink to their real size. The whole stack is rebased onto current `main` (`9f6dcb5`) as of now. `#13020` is compile-verified on Spark 3.4 / 3.5 / 4.0 / 4.1, and the stack tip builds green on 4.2 (`clean install -Pspark-ut`). Repeating the two asks from my earlier comment, since they're what actually gates progress: 1. **A committer needs to `workflow_dispatch` `docker_image.yml`.** #13021 adds the Spark 4.2 resources to the Dockerfile, but the image only rebuilds on a Sunday cron. Until it's rebuilt, #13022's UT lanes can't run regardless of code quality — so the test PRs have no CI signal yet. This is the single biggest blocker. 2. **#13022 must be rebase-merged, not squashed**, to preserve `git log --follow` through the `spark41 → spark42` rename commit (per #11352). And one design question I'd rather resolve early than after review: the `getCommonPartitionValues → None` degradation on 4.2 only, described in #13021. Happy to pursue a fuller solution if that's preferred over landing the gap. Generated-by: GitHub Copilot CLI (Claude Opus 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
