marin-ma commented on code in PR #13016:
URL: https://github.com/apache/gluten/pull/13016#discussion_r4025482328
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -696,6 +696,16 @@ object VeloxConfig extends ConfigRegistry {
.booleanConf
.createWithDefault(true)
+ val NATIVE_UDF_WITHOUT_FALLBACK =
+
buildStaticConf("spark.gluten.sql.columnar.backend.velox.nativeUDFWithoutFallback")
Review Comment:
perhaps rename `nativeUDFWithoutFallback` to `nativeUDF.bypassRegistration`
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxRuleApi.scala:
##########
@@ -67,6 +70,12 @@ object VeloxRuleApi {
if (BackendsApiManager.getSettings.supportAppendDataExec()) {
injector.injectPlannerStrategy(SparkShimLoader.getSparkShims.getRewriteCreateTableAsSelect(_))
}
+
+ val registerByName = Option(SparkEnv.get)
Review Comment:
You can add a function to get the configuration in `VeloxConfig` and use
`VeloxConfig.get.yourFunc` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
