felipepessoto opened a new pull request, #13041:
URL: https://github.com/apache/gluten/pull/13041

   ## What changes are proposed in this pull request?
   
   Preserve `TIMESTAMP_NTZ` literal types and values through the 
JVM/Substrait/Velox conversion paths. NTZ values use Substrait's `timestamp` 
literal field, while regular timestamps continue to use `timestamp_tz`.
   
   The patch carries logical types into reverse literal conversion, preserves 
complete types for null literals, and handles scalar vector-backed constants 
without treating them as virtual-table output. It also connects the existing 
JVM NTZ literal node to scalar, collection, and struct literal construction.
   
   This is a separate follow-up to [the literal-conversion review 
comment](https://github.com/apache/gluten/pull/12967#discussion_r4029736350) on 
apache/gluten#12967. It is based on `main` and includes the NTZ type mapping 
needed by its own literal and Values round trips. It does not include the 
aggregation validator, shuffle, or Delta statistics changes from that PR.
   
   Related to apache/gluten#12538.
   
   ## How was this patch tested?
   
   Native conversion regressions check serialized literal fields, logical 
types, and exact microsecond values for scalar constants, vector-backed 
constants, typed nulls, Values plans, and array literals. Both regular 
timestamps and NTZ values are covered, including pre-epoch values.
   
   The dedicated Spark 4.1 `GlutenTimestampNtzLiteralSuite` checks JVM 
scalar/array/struct literal serialization and a non-foldable `timestampadd` 
expression with native-plan assertions. Using a row-dependent expression 
prevents Spark constant folding from hiding the native literal path.
   
   Existing related native conversion cases, formatting, and license-header 
checks were also run.
   
   ## Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: GitHub Copilot CLI 1.0.83
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to