Copilot commented on code in PR #13054:
URL: https://github.com/apache/gluten/pull/13054#discussion_r4045970430
##########
gluten-substrait/src/test/scala/org/apache/spark/softaffinity/SoftAffinitySuite.scala:
##########
@@ -269,5 +269,16 @@ class SoftAffinitySuite extends QueryTest with
SharedSparkSession with Predicate
("3", "host-3"),
("4", "host-3"))
))
+
+ executorsListListener.onExecutorRemoved(removedEvent0)
+ executorsListListener.onExecutorRemoved(removedEvent1)
+ executorsListListener.onExecutorRemoved(removedEvent2)
+ executorsListListener.onExecutorRemoved(removedEvent3)
+ executorsListListener.onExecutorRemoved(removedEvent4)
Review Comment:
`SoftAffinityManager` is a process-global singleton, so this cleanup is
skipped whenever any assertion or partition check above fails. In that case the
test leaves executors registered and can poison the later soft-affinity suites
(the CI failure this change targets); move the removals into a guaranteed
`afterEach`/`finally` cleanup rather than relying on reaching the end of the
test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
