wecharyu commented on code in PR #13018:
URL: https://github.com/apache/gluten/pull/13018#discussion_r4056440714
##########
cpp/bolt/memory/BoltColumnarBatch.cc:
##########
@@ -64,14 +64,14 @@ void BoltColumnarBatch::ensureFlattened() {
flattened_ = true;
}
-std::shared_ptr<ArrowSchema> BoltColumnarBatch::exportArrowSchema() {
+std::shared_ptr<ArrowSchema> BoltColumnarBatch::exportArrowSchema(bool) {
auto out = std::make_shared<ArrowSchema>();
ensureFlattened();
bolt::exportToArrow(rowVector_, *out, ArrowUtils::getBridgeOptions());
return out;
}
-std::shared_ptr<ArrowArray> BoltColumnarBatch::exportArrowArray() {
+std::shared_ptr<ArrowArray> BoltColumnarBatch::exportArrowArray(bool) {
auto out = std::make_shared<ArrowArray>();
ensureFlattened();
bolt::exportToArrow(rowVector_, *out, rowVector_->pool(),
ArrowUtils::getBridgeOptions());
Review Comment:
Add new backend api `supportLargeVarTypes()` to disable arrow var type for
bolt backend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
